move env QR_CODE_MAX_UPLOAD_LENGTH to runtime

.github/workflows/release.yml

@@ -15,6 +15,7 @@ on:
   push:
     branches: 
       - main
+      - 170-move-env-QR_CODE_MAX_UPLOAD_LENGTH-to-runtime
   release:
     types: [published]
 

config/config.exs

@@ -28,10 +28,6 @@ config :qrstorage, QrstorageWeb.Endpoint,
     layout: false
   ]
 
-# This is what will be used for the calculation on the client side. We add a buffer to account for deltas
-# and overhead in the endpoint configuration, so the server actually allows for a bit more:
-config :qrstorage, max_upload_length: System.get_env("QR_CODE_MAX_UPLOAD_LENGTH", "2666666")
-
 # Configures Elixir's Logger
 config :logger, :console,
   format: "$time $metadata[$level] $message\n",

config/runtime.exs

@@ -54,6 +54,10 @@ config :qrstorage, Qrstorage.Repo,
     ]
   ]
 
+# This is what will be used for the calculation on the client side. We add a buffer to account for deltas
+# and overhead in the endpoint configuration, so the server actually allows for a bit more:
+config :qrstorage, max_upload_length: System.get_env("QR_CODE_MAX_UPLOAD_LENGTH", "2666666")
+
 # Set possible translations
 default_locale =
   case config_env() do

docker-compose.yml

@@ -7,9 +7,9 @@ services:
       target: development
     tty: true
     environment:
-      DATABASE_USER: ${POSTGRES_USER:-postgres}
-      DATABASE_USER_PASSWORD: ${POSTGRES_PASSWORD:-postgres}
-      DATABASE_NAME: ${POSTGRES_DB:-qrstorage_dev}
+      DATABASE_USER: ${POSTGRES_USER:-qrstorage-user}
+      DATABASE_USER_PASSWORD: ${POSTGRES_PASSWORD:-qrstorage-password}
+      DATABASE_NAME: ${POSTGRES_DB:-qrstorage-dev}
       DATABASE_PORT: 5432
       DATABASE_HOST: postgres
       DATABASE_SSL: "false"
@@ -80,9 +80,9 @@ services:
   postgres:
     image: postgres:15
     environment:
-      POSTGRES_USER: ${POSTGRES_USER:-postgres}
-      POSTGRES_PASSWORD: ${POSTGRES_PASSWORD:-postgres}
-      POSTGRES_DB: ${POSTGRES_DB:-qrstorage_dev}
+      POSTGRES_USER: ${POSTGRES_USER:-qrstorage-user}
+      POSTGRES_PASSWORD: ${POSTGRES_PASSWORD:-qrstorage-password}
+      POSTGRES_DB: ${POSTGRES_DB:-qrstorage-dev}
       PGDATA: /var/lib/postgresql/data/pgdata
     restart: always
     # Exposing the port is not needed unless you want to access this database instance from the host.

lib/qrstorage_web/endpoint.ex

@@ -36,16 +36,10 @@ defmodule QrstorageWeb.Endpoint do
   plug Plug.RequestId
   plug Plug.Telemetry, event_prefix: [:phoenix, :endpoint]
 
-  # account for deltas and overhead for the upload length. deltas are roughly the same size as the actual input,
-  # so * 2 for deltas, plus 0.2 buffer for overhead and text characters:
-  upload_length_buffer = 2.2
-  max_upload_length = String.to_integer(Application.compile_env(:qrstorage, :max_upload_length))
-
   plug Plug.Parsers,
     parsers: [:urlencoded, :multipart, :json],
     pass: ["*/*"],
-    json_decoder: Phoenix.json_library(),
-    length: ceil(max_upload_length * upload_length_buffer)
+    json_decoder: Phoenix.json_library()
 
   plug Plug.MethodOverride
   plug Plug.Head