[hibernate search] Introduce interfaces for the database- and search-related functions of the services #6051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From FindBugs. SimpleDateFormat class is not thread-safe. Using an object across threads may result in undefined behavior.
This is done in anticipation of the upcoming renaming of the X packages.
This also considers non-empty strings that consist of white space only as empty, which, as far as I can see, is the more correct choice in all places.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #5760 1c) -- part 2
1c) part 2 introduces interfaces for the database- and search-related functionality of the data services, that by now still use the search index. The data services implement a lot of functionality, some of which is thoroughly covered by tests, but otherwise is not used in the code.
The aim of this step was to clarify and document which of these functions are actually used in the source code—and you can see that there isn't that much—and how they work, in particular to clarify the implicit functionality: Does a function search on all data? Or does it access the user session in the background, and look only for the data for the client, for which the logged-in user is currently working? Or are there other criteria, if so, which ones, and where are they passed?
You can see that this is not implemented uniformly everywhere, and not every function name describes exactly, what the function actually does. Clarifying this was a prerequisite for a re-implementation with identical functionality, which will follow in the next step.
For better reviewability, this part is provided as a separate pull request.
Follow-up pull request to #6032 (immediate diff)