add conditionals to hide arrow and dot buttons if only one slide #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davisagli
reviewed
Dec 20, 2023
|
@davisagli another use would be to hide the arrow buttons when it is a single-slide, there is a conditional around them, but no way of hiding them just for the single-slide case. Should we include this condition around them as well? |
|
@danalvrz Yes, I think it makes sense to also skip rendering the arrow buttons if there is only one slide. |
sneridagh
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To have a trigger for styling single-slide Slider blocks (ex. hide
.slider-dots)