Block model v3 #17
Open
Block model v3 #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davisagli
reviewed
Oct 24, 2024
| formData={data} | ||
| fieldIndex={data.index} | ||
| block={block} | ||
| navRoot={navRoot} | ||
| contentType={contentType} |
There was a problem hiding this comment.
For any props that aren't used directly here, you can do this on line 7:
const { data, block, schemaEnhancer, ...rest } = props;
And then pass them on together with {...rest} in the component.
davisagli
reviewed
Oct 24, 2024
Co-authored-by: David Glick <david@glicksoftware.com>
sneridagh
requested changes
Oct 25, 2024
| @@ -36,6 +40,12 @@ | |||
| .block-editor-separator { | |||
| clear: both; | |||
|
|
|||
| &.has--shortLine--true .block.separator { | |||
There was a problem hiding this comment.
Where does this come from?
I'd not do the shortline as in a custom classname, we have the Stylewrapper for it! Even if we only want to inject a classname (not all in the world have to be CSS properties). What do you think?
| id: 'default', | ||
| title: 'Default', | ||
| fieldsets: [{ id: 'default', title: 'Default', fields: ['shortLine'] }], | ||
| properties: { |
There was a problem hiding this comment.
I'd do this as a stylewrapper property.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.