Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix variables order, add !default to all theme vars #81

Merged
merged 2 commits into from
May 24, 2023
Merged

Fix variables order, add !default to all theme vars #81

merged 2 commits into from
May 24, 2023

Conversation

sneridagh
Copy link
Member

Following: https://6.docs.plone.org/volto/addons/theme.html#variables-addonsthemecustomizationsvariables

Adding !default to all theme vars so they can be overridable from the add-ons. Move addonsThemeCustomizationsVariables to the top.

@sneridagh sneridagh requested review from ericof and danalvrz May 24, 2023 08:58
ericof
ericof approved these changes May 24, 2023
View reviewed changes
Copy link
Contributor

@ericof ericof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

danalvrz
danalvrz approved these changes May 24, 2023
View reviewed changes
Copy link
Contributor

@danalvrz danalvrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It all looks good!

@sneridagh sneridagh merged commit c865e30 into main May 24, 2023
@sneridagh sneridagh deleted the fixvariables branch May 24, 2023 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericof ericof ericof approved these changes

@danalvrz danalvrz danalvrz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sneridagh @ericof @danalvrz