-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Color contrast check #454
Color contrast check #454
Conversation
@danalvrz @sneridagh shouldn't instead of putting everything on plone site. I simple controlpanel provided regarding the theming and assets. So that everything is at one place. Also, we can also make give them some config directly in that controlpanel. Giving them proper cms feels instead of touching code. Just my thoughts after seeing this. |
@iFlameing yes, this placement will be probably temporary. We are planning to move it to its own view, however, we need some backend improvements that are still not ready. |
@danalvrz let's try to merge this soon, could you please solve conflicts and merge? |
@danalvrz let's talk later, but I've switched for now to a new color picker widget, we might have to transfer all the code there or make it "shareable" between widgets (my preferred option). |
Replaced by #463 |
This PR adds a color contrast check to the theming widget to help with accessibility. If the color contrast ratio between background and foreground colors is < 4.5 it displays a warning message under the color picker with the current color contrast ratio, the WCAG compliance level & a link to further info about color contrast accessibility.
Screenshot: