VLT 6 - New color schemas, CSS properties powered, new widgets #420
Conversation
* main: (27 commits) Update to V18a46 (#419) Fix deploy Get rid of all barrel imports, ESlint rule to enforce it. (#418) Release 5.0.1 Changelog Changelog Added lint rule Updates from Oct24 (#417) Update versions to latest volto-highlight-block, volto-button-block (#408) Fix eslint config (#407) Release 5.0.0 Better changelog Upgrade to a39, enable new image widget (#405) Finish interrupted push Fixes #400, install in Volto 17 Fix Invalid html structure in caption component (#401) build deps Upgrade to Volto a37 (#403) Release 4.0.0 Fix release-it script ...
|
@danalvrz la build se queja: Deprecation Warning: The selector ".blocks-group-wrapper * a:not(.item)" is invalid CSS. It will be omitted from the generated CSS.
This will be an error in Dart Sass 2.0.0.
More info: https://sass-lang.com/d/bogus-combinators
╷
26 │ :not(.teaser >) a:not(.item) {
│ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
╵
../../../packages/volto-light-theme/src/theme/_bgcolor-blocks-layout.scss 26:3 @import
../../../packages/volto-light-theme/src/theme/_layout.scss 436:9 @import
../../../packages/volto-light-theme/src/theme/main.scss 7:9 root stylesheetLe puedes echar un vistazo? |
| accordion: BlockConfigBase; | ||
| hero: BlockConfigBase; | ||
| slateTable: BlockConfigBase; | ||
| } |
There was a problem hiding this comment.
Needing to write this seems really annoying. Is there no way to declare that every property in the blocksConfig object has a BlockConfigBase as a value?
There was a problem hiding this comment.
If you want to retain autocomplete-ability as well? I'm still a newbie in TS... but we will reach there. I will ask Piero how they do it. It's annoying but it's right, less magic, and less error prone.
We still have to learn a lot of TS, I'd say let's start simple, and improve bit by bit as we feel more confortable and gain knowledge of it.
packages/volto-light-theme/src/customizations/volto/reducers/content/content.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
@sneridagh @danalvrz I think we can go ahead with an alpha for VLT 6, but I'm commenting on a few things that seem important.
We also need docs before it's ready for a final release. But as we discussed, you kind of need an alpha in order to test upgrading your sites, which will be part of the process for creating the documentation.
| New widths definitions | ||
| Removed Container Query Polyfill configuration profile | ||
| New Background widgets based in `@plone/components` | ||
| @danalvrz @sneridagh |
There was a problem hiding this comment.
This list is missing some of the changes that are included (aspect ratio field, footer links & logos, aboveHeader slot). And, not all of them are breaking.
…idget. Complete changelog.
|
@davisagli @danalvrz merging and releasing! |
This supersedes: vltthreeandahalf branch