Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed the "Overview" Message #276

Merged
merged 8 commits into from
Nov 30, 2023

Conversation

Molochem
Copy link
Contributor

As per https://github.com/kitconcept/kitconcept.com/issues/40 the "Overview" React Message is not longer needed

@Molochem Molochem marked this pull request as ready for review November 29, 2023 12:16
@jackahl jackahl requested a review from sneridagh November 29, 2023 12:30
@steffenri steffenri self-requested a review November 29, 2023 13:55
Copy link
Member

@steffenri steffenri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Molochem 2 things:

  1. It's not a bugfix. It's internal.
  2. Run "yarn i18n" to also remove the translation from the .po files.

rest lgtm.

@tisto
Copy link
Member

tisto commented Nov 29, 2023

Not sure if that is really "internal". Think about someone who uses volto-light-theme. One could even argue that this is a breaking change. Up to the release manager @sneridagh to decide.

@davisagli
Copy link
Member

Yeah "internal" is for things that are only visible to developers.

@sneridagh
Copy link
Member

If it's not breaking, then it's a bugfix ;) I think we can go with that one. I didn't like it either, so I'm glad we are getting rid of it.

@sneridagh
Copy link
Member

@Molochem you still have to re-run yarn i18n

@sneridagh sneridagh merged commit fe60448 into kitconcept:main Nov 30, 2023
@Molochem Molochem deleted the Remove-Overview-in-Fat-menu branch November 30, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants