-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed the "Overview" Message #276
Removed the "Overview" Message #276
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Molochem 2 things:
- It's not a bugfix. It's internal.
- Run "yarn i18n" to also remove the translation from the .po files.
rest lgtm.
Not sure if that is really "internal". Think about someone who uses volto-light-theme. One could even argue that this is a breaking change. Up to the release manager @sneridagh to decide. |
Yeah "internal" is for things that are only visible to developers. |
If it's not breaking, then it's a bugfix ;) I think we can go with that one. I didn't like it either, so I'm glad we are getting rid of it. |
@Molochem you still have to re-run |
As per https://github.com/kitconcept/kitconcept.com/issues/40 the "Overview" React Message is not longer needed