Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix responsive spacings & font sizes #181

Merged
merged 2 commits into from
Jul 26, 2023
Merged

Conversation

danalvrz
Copy link
Contributor

@danalvrz danalvrz commented Jul 26, 2023

  • Disabled dynamic fonts for in-grid headings in mobile
  • Fixed top/bottom paddings for grid columns
  • Added media queries to spacing mixins
  • Other minor spacing bugfixes

@danalvrz danalvrz requested review from sneridagh and iFlameing July 26, 2023 02:53
@sneridagh
Copy link
Member

@danalvrz @iFlameing

I've been thinking on the subject on when to use media queries and when to use container queries. It has to do with the thing that we were discussing yesterday about the edit mode 1:1 with the view mode. So I came up with a rule (which we can discuss, of course):

We use media queries when the styling it's generic enough to apply only to the View.

We use container queries when do care explicitly about how the styling is being applied in edit mode as well and we want the content area to behave 1:1 with the view mode.

Reason: The container queries allow us to abstract the width from the sidebar and toolbar in edit mode, showing the content area as it will be in that size, in view mode.

Remember: The margins in responsive are being taken care with container queries in layout.scss. So everything related to that, goes like it works in there, with container queries. See implementations for details in case you need it.

I will put this info in the README.

I'm merging this one, since I see that all changes applies to media queries. If we need to refine them because we see that the edit mode differs too much, we can move them to container queries. It seems to me that all are related to spacing which does not make much sense in edit mode, and font sizes, which is also ok in edit mode (for now).

@sneridagh sneridagh merged commit 31d68ea into main Jul 26, 2023
@sneridagh sneridagh deleted the fix-responsive-spacings branch July 26, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants