Update to Volto 17a21 + Deprecate volto-image-block - Use new core Image component
#177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sneridagh Maybe you need to re-run yarn? |
ericof
approved these changes
Jul 25, 2023
davisagli
reviewed
Jul 25, 2023
| value, | ||
| }); | ||
| }} | ||
| // END CUSTOMIZATION |
There was a problem hiding this comment.
@sneridagh This customization should go into volto, right?
davisagli
reviewed
Jul 25, 2023
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have to be careful with this one, but this is the initial work needed.
The gist: I think the DLR image component is overengineered and not usable, and the DX is very poor. I still cannot make it work and instantiate it at the first shot. I think we should move to use the new image component in core. (Volto 17a21). The DX and the simplicity of it is far better.
The only downside is that the core one does not use
blurhash. Any other opinions?NOTE for this August (while I'm on holidays): You can update Volto to latest without this, the image component in
volto-image-blockwill take over. Up to you to merge this and follow up, an exhaustive QA should be done on all places where this is used.