Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Listing block style fixes #130

Merged
merged 5 commits into from
Jul 10, 2023
Merged

Listing block style fixes #130

merged 5 commits into from
Jul 10, 2023

Conversation

danalvrz
Copy link
Contributor

@danalvrz danalvrz commented Jul 7, 2023 •
edited
Loading

  • Fixed styles for the Linsting block, by adding a customization of View.jsx
  • Minor label, and margin fix for the Button block

@danalvrz danalvrz requested a review from sneridagh July 7, 2023 01:38
@sneridagh
Copy link
Member

@danalvrz let's talk about this one, I think we already have this in place in DLR, should be done in the StyleWrapper conf.

https://github.com/kitconcept/intra.kitconcept.com/blob/91cc59af6a9189503c4d1e7e0774466f8ae68533/src/index.js#L103

in DLR:

https://github.com/kitconcept/dlr-internet/blob/f73da407773513589d68211dd8e777bee5e3f12e/frontend/src/addons/volto-dlr/src/customizations/volto/components/manage/Blocks/Block/StyleWrapper.jsx#L57

@sneridagh sneridagh merged commit daaf547 into main Jul 10, 2023
@sneridagh sneridagh deleted the fix-listing-styles branch July 10, 2023 07:39
sneridagh
sneridagh reviewed Jul 10, 2023
View reviewed changes
src/theme/blocks/_listing.scss
display: none;
}
}
&:last-child:not(> .column) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danalvrz This one is failing in the compilation:

image

Please take a look.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in #134

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sneridagh sneridagh sneridagh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danalvrz @sneridagh