Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various log_group / stream_name warnings in tests #180

Merged
merged 1 commit into from
Jan 28, 2023

Conversation

tomkins
Copy link
Contributor

@tomkins tomkins commented Jan 27, 2023

Was trying to fix another issue, but noticed a few easy wins for updating the tests to emit fewer warnings, mostly due to:

if log_group is not None:
if log_group_name != __name__:
raise WatchtowerError("Both log_group_name and deprecated log_group parameter specified")
warnings.warn("Please use log_group_name instead of log_group", DeprecationWarning)
self.log_group_name = log_group
if stream_name is not None:
if log_stream_name != DEFAULT_LOG_STREAM_NAME:
raise WatchtowerError("Both log_stream_name and deprecated stream_name parameter specified")
warnings.warn("Please use log_stream_name instead of stream_name", DeprecationWarning)
self.log_stream_name = stream_name

@kislyuk kislyuk merged commit db3b4e8 into kislyuk:develop Jan 28, 2023
@tomkins tomkins deleted the fix-name-warnings branch January 28, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants