Update empty message filtering to catch formatted string case #162
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Empty message filtering added in 2.0 does not catch the edge case
where the empty message is delivered as a formatted string (see repro example below).
Update tests to catch future regressions of this case
Update .gitignore to ignore the coverage file created by make tests
repro
Running the above script yields this failure, where the empty message fails cloudwatch local validation and the whole batch of logs are not emitted to cloudwatch:
Running with the changes in this PR yields the expected behaviour of just emitting the warning for empty messages, but the other two valid messages are still sent to cloudwatch: