Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fall back to a configuration file if role description does not contain config token. #39

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

renaudhager
Copy link
Contributor

Keymaker will fall back on a config file if there is no config token present in role description.
See issue #33

… will fall back on a config file if there is no config token present in role description.
@renaudhager renaudhager changed the title Fall back to a configuration file is role description does not contain config token. Fall back to a configuration file if role description does not contain config token. Mar 6, 2018
@kislyuk
Copy link
Owner

kislyuk commented May 29, 2018

Thanks for your contribution!

The overall idea here is great, but before this PR can be merged, it must:

  • Use a standard or conventional file format and location (such as /etc/keymaker/config.yml). The only reason I used non-standard markup in the role description is that standard JSON/YAML/etc. markup characters are not allowed there.
  • Use fully correct English in complete sentences in the documentation
  • Conform to PEP-8.

- Fixed a bug when Role description is empty.
- Updated README.md.
@renaudhager renaudhager force-pushed the feature-config-file branch from e012bb6 to 130c6c2 Compare July 29, 2018 17:46
@quagly
Copy link

quagly commented Dec 19, 2018

I also only use cloudformation for role/instance profile creation and cloudformation does not support descriptions. config file seems like a reasonable approach, but I also like the idea of managing everything from within IAM. I wonder if role path may be a better option. /keymaker/... I am just getting started with keymaker and haven't implemented groups yet. When I require groups I may try this branch or try to use role path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants