Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add extra condition to avoid wrong on clause on MorphTo joins #192

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Add extra condition to avoid wrong on clause on MorphTo joins #192

merged 1 commit into from
Nov 26, 2024

Conversation

sebj54
Copy link
Contributor

@sebj54 sebj54 commented Nov 26, 2024 •
edited
Loading

Closes #191

I did not add any test because there was already one failing, fixed by my commit.

Before

image

After

image

luisdalmolin
luisdalmolin approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@luisdalmolin luisdalmolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff, I've confirmed this works. Thank you!

@luisdalmolin luisdalmolin merged commit 3c1af9b into kirschbaum-development:master Nov 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luisdalmolin luisdalmolin luisdalmolin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Power join on MorphTo relations does not work since Laravel v11.33.0
2 participants
@sebj54 @luisdalmolin