Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RNKC-076] - various small updates for example #84

Merged
merged 1 commit into from
Oct 7, 2022

Conversation

kirillzyusko
Copy link
Owner

📜 Description

Updated example project with some small fixes.

💡 Motivation and Context

I decided to rework KeyboardAnimation example because of several reasons:

  • now two circles stick to the bottom of the screen <- it will be easier to detect any insets changes (these circles will be cut);
  • progress value is shown at the top of the screen (it will never be overlapped by the keyboard);
  • text input field will be always covered by keyboard;

📢 Changelog

JS

  • reworked KeyboardAnimation example;
  • added useResizeMode where it was needed to assure, that everything works on API < 30 too;

Android

  • set adjustPan for FabricExample on Android (to assure that native module actually changes necessary values);

🤔 How Has This Been Tested?

Tested manually on Android (API 32, API 28) and iPhone (iOS 15.5).

📸 Screenshots (if appropriate):

Before After
image image

📝 Checklist

  • CI successfully passed

@kirillzyusko kirillzyusko added the example Anything related to example project label Oct 7, 2022
@kirillzyusko kirillzyusko self-assigned this Oct 7, 2022
@kirillzyusko kirillzyusko merged commit fb3294a into main Oct 7, 2022
@kirillzyusko kirillzyusko deleted the refactor/updated-example branch October 7, 2022 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
example Anything related to example project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant