fix: set shared values in layout effects

[QichenZhu]

📜 Description

Fixed KeyboardAvoidingView not updating if the keyboard closes before binding event handlers.

💡 Motivation and Context

There’s a short timing gap after KeyboardAvoidingView initializes and before it listens for keyboard changes. If the keyboard closes during this gap, it isn’t aware that the keyboard has already closed.

Closes #836.

Related to:
$ Expensify/App#56156
PROPOSAL: Expensify/App#56156 (comment)

📢 Changelog

JS

• set shared values in useLayoutEffect

🤔 How Has This Been Tested?

Tested locally on OnePlus 8 Pro Android 13.

📸 Screenshots (if appropriate):

Before	After
react-native-keyboard-controller-android.mp4	after.mp4

📝 Checklist

• CI successfully passed
• I added new mocks and corresponding unit-tests if library API was changed

[github-actions]

📊 Package size report

Current size	Target Size	Difference
169866 bytes	169847 bytes	19 bytes 📈

[QichenZhu]

Checks have passed, but I noticed two e2e tests are flaky on iOS 16:

• Interactive keyboard interactions › should have expected state when keyboard is opened
• Native stack › should have expected state when emoji keyboard is opened

They failed on the first try and passed when reran.

Are they known issues or related to this PR?

[kirillzyusko]

Are they known issues or related to this PR?

This is a known issue. Simulator on first boot works really slow, but after 15-20 minutes becomes working normally (this is why I added test repeat). So yeah, ignore it 😅

May I ask you to attach videos from your reproduction app, how it was before and how it looks after?

[kirillzyusko]

@QichenZhu do you need a new release? Asking because in 1.16 release I did some modification to how selection coordinates get calculated on Android (and in Expensify we heavily rely on those coordinates). And if you update the lib to the latest version, then potentially you'll need to check that part as well, to be sure it works as before (but it's out of the scope of the initial issue).

So asking how do you want to fix that in Expensify? Via patch or via lib update?

[QichenZhu]

Thank you so much @kirillzyusko for the quick action on this.

I believe the plan is to upgrade the library, as mentioned in @roryabraham's comment:

we'll also need to upgrade react-native-keyboard-controller in this repo.

[kirillzyusko]

Okay @QichenZhu

I'll prepare release today 👍

[kirillzyusko]

Published 1.16.6 😌