fix: XCode warnings #766
Merged
fix: XCode warnings #766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Package size report
|
2 tasks
kirillzyusko
added a commit
that referenced
this pull request
Jan 21, 2025
## 📜 Description Fixed newly discovered warnings. ## 💡 Motivation and Context In paper example I've seen even more warnings and fixed them as well 🙂 initially these warning were added in #727 Follow up for #766 ## 📢 Changelog <!-- High level overview of important changes --> <!-- For example: fixed status bar manipulation; added new types declarations; --> <!-- If your changes don't affect one of platform/language below - then remove this platform/language --> ### iOS - fixed 2 warnings in `KeyboardMovementObserver`; ## 🤔 How Has This Been Tested? Tested manually. ## 📝 Checklist - [x] CI successfully passed - [x] I added new mocks and corresponding unit-tests if library API was changed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Fixed warnings during project compilation.
💡 Motivation and Context
Warnings is an indicator of a bad code sign. Let's make sure that we don't have such "code smells" and our codebase don't throw any warnings during compilation 😎
📢 Changelog
iOS
UIViewcasting.🤔 How Has This Been Tested?
Tested on CI.
📸 Screenshots (if appropriate):
📝 Checklist