Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: interrupt sudo command in runtime installation #688

Merged
merged 8 commits into from
Nov 15, 2024

Conversation

kirillzyusko
Copy link
Owner

@kirillzyusko kirillzyusko commented Nov 14, 2024

📜 Description

Fixed an issue when additional runtime installation can not be terminated after 10 minutes.

💡 Motivation and Context

When using nick-fields/retry and we interrupt sudo command then we are getting errors like this nick-fields/retry#114 or nick-fields/retry#124

To overcome this problem I decided to create own script for retrying a command. This PR delivers that.

📢 Changelog

CI

  • replace nick-fields/retry with own action;

🤔 How Has This Been Tested?

Reduced timeout to 2 minutes and verified that action was repeated 3 times with 1 minute delay between attempts.

📸 Screenshots (if appropriate):

image

📝 Checklist

  • CI successfully passed
  • I added new mocks and corresponding unit-tests if library API was changed

@kirillzyusko kirillzyusko added 🍎 iOS iOS specific CI CI (github actions) labels Nov 14, 2024
@kirillzyusko kirillzyusko self-assigned this Nov 14, 2024
Copy link
Contributor

github-actions bot commented Nov 14, 2024

📊 Package size report

Current size Target Size Difference
159566 bytes 159566 bytes 0 bytes 📉

@kirillzyusko kirillzyusko added the e2e Anything about E2E tests label Nov 14, 2024
@kirillzyusko kirillzyusko marked this pull request as ready for review November 15, 2024 10:55
@kirillzyusko kirillzyusko merged commit c334a33 into main Nov 15, 2024
9 checks passed
@kirillzyusko kirillzyusko deleted the fix/installation-runtime-retry-interrupt-sudo branch November 15, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI CI (github actions) e2e Anything about E2E tests 🍎 iOS iOS specific
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant