Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RNKC-050] - fixed iOS compilation issues #31

Merged
merged 1 commit into from
Jun 3, 2022

Conversation

kirillzyusko
Copy link
Owner

Description

Fixed compilation in XCode.

Motivation and Context

In https://github.com/kirillzyusko/react-native-keyboard-controller/pull/23/files#diff-8975efc71b3a8dead3c983b4720088d0f3348a58f07f9e8ed278ea90165486a4 I've renamed param from reactTag to viewTag, but forgot to change it in other places of library 🤦

Changelog

iOS

  • reactTag -> viewTag in events creation;

How Has This Been Tested?

Tested manually in example app.

Checklist

  • CI successfully passed

@kirillzyusko kirillzyusko merged commit 2f242c8 into main Jun 3, 2022
@kirillzyusko kirillzyusko deleted the bugfix/ios-compilation branch June 3, 2022 20:33
@kirillzyusko kirillzyusko mentioned this pull request Jun 4, 2022
1 task
@kirillzyusko kirillzyusko added the 🍎 iOS iOS specific label Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍎 iOS iOS specific
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant