[RNKC-041] - correct subscribe/unsubscribe mechanism for keyboard events on iOS #18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reorganised subscription mechanism as per this SO answer.
Context And Motivation
The problem with old code was in the fact, that if subview is getting removed, then we unsubscribe from keyboard events. It's incorrect behaviour, since we should unsubscribe from events only in case if view itself is getting removed (not subviews, not sibling views).
Code to test
It was reproducible using code below: