-
-
Notifications
You must be signed in to change notification settings - Fork 89
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
refactor: move all interactive keyboard code to dedicated `interactiv…
…e` folder (Android) (#353) ## 📜 Description Move all interactive keyboard code to dedicated `interactive` folder/package in kotlin/Android. ## 💡 Motivation and Context Ideally in root android folder I'd like to keep a single `package` file and all other code should be placed in folders. Initially I created generic purpose folders, like `events`/`listeners`/`views` etc. However sometimes it may be hard to create generic purpose folders for specific files. Theoretically I could create folders `controllers`/`providers`, but they would contain only single files. So I took an inspiration from #346 PR, where I created `traversal` folder for keeping functionality related to view traversal/keyboard toolbar. And in this PR I moved all interactive-keyboard related code into `interactive` folder - it keeps file-system clean 😎 ## 📢 Changelog <!-- High level overview of important changes --> <!-- For example: fixed status bar manipulation; added new types declarations; --> <!-- If your changes don't affect one of platform/language below - then remove this platform/language --> ### CI - free up disk for `e2e` tests (Android); ### Android - added `interactive` folder; - move `interpolators` folder to `interactive`; - moved `InteractiveKeyboardProvider` and `KeyboardAnimationController` to `interactive` folder. ## 🤔 How Has This Been Tested? Tested on CI. ## 📸 Screenshots (if appropriate): |Before|After| |-------|-----| |<img width="279" alt="image" src="https://github.com/kirillzyusko/react-native-keyboard-controller/assets/22820318/e441f44b-865f-4fb7-97c1-d303ee951bbb">|<img width="351" alt="image" src="https://github.com/kirillzyusko/react-native-keyboard-controller/assets/22820318/0abc31f3-6a38-4a6e-aa44-4f9dbd95c741">| ## 📝 Checklist - [x] CI successfully passed - [x] I added new mocks and corresponding unit-tests if library API was changed
- Loading branch information
1 parent
6859701
commit a70c6fd
Showing
8 changed files
with
17 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...controller/InteractiveKeyboardProvider.kt → ...nteractive/InteractiveKeyboardProvider.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...controller/KeyboardAnimationController.kt → ...nteractive/KeyboardAnimationController.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...dcontroller/interpolators/Interpolator.kt → ...interactive/interpolators/Interpolator.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...ntroller/interpolators/IosInterpolator.kt → ...eractive/interpolators/IosInterpolator.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...oller/interpolators/LinearInterpolator.kt → ...ctive/interpolators/LinearInterpolator.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters