[RNKC-044] - android lint (#26)

* [RNKC-044] - android lint * [RNKC-044] - suppress ViewConstructor warning * [RNKC-044] - clean up workflow file
kirillzyusko · May 25, 2022 · 82bb1a5 · 82bb1a5
1 parent cf27eb0
commit 82bb1a5
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 1 deletion.
diff --git a/.github/workflows/verify-kotlin.yml b/.github/workflows/verify-kotlin.yml
@@ -18,3 +18,20 @@ jobs:
         with:
           ktlint_version: 0.45.2
       - run: ktlint "android/src/**/*.kt"
+  android-lint:
+    runs-on: ubuntu-latest
+    name: Android Lint
+    defaults:
+      run:
+        working-directory: ./android
+    steps:
+      - uses: actions/checkout@v2
+      - name: Setup JDK 11
+        uses: actions/setup-java@v3
+        with:
+          distribution: 'microsoft'
+          java-version: '11'
+      - name: Install dependencies
+        run: yarn install --frozen-lockfile --cwd ..
+      - name: Run Gradle Lint
+        run: ./gradlew lint
diff --git a/android/build.gradle b/android/build.gradle
@@ -41,7 +41,7 @@ android {
     }
   }
   lintOptions {
-    disable 'GradleCompatible'
+    warningsAsErrors true
   }
   compileOptions {
     sourceCompatibility JavaVersion.VERSION_1_8

diff --git a/android/gradle.properties b/android/gradle.properties
@@ -1,3 +1,5 @@
 KeyboardController_kotlinVersion=1.3.50
 KeyboardController_compileSdkVersion=29
 KeyboardController_targetSdkVersion=29
+
+android.useAndroidX=true
diff --git a/android/src/main/java/com/reactnativekeyboardcontroller/EdgeToEdgeReactViewGroup.kt b/android/src/main/java/com/reactnativekeyboardcontroller/EdgeToEdgeReactViewGroup.kt
@@ -1,9 +1,11 @@
 package com.reactnativekeyboardcontroller
 
+import android.annotation.SuppressLint
 import androidx.core.view.WindowCompat
 import com.facebook.react.uimanager.ThemedReactContext
 import com.facebook.react.views.view.ReactViewGroup
 
+@SuppressLint("ViewConstructor")
 class EdgeToEdgeReactViewGroup(private val reactContext: ThemedReactContext) : ReactViewGroup(reactContext) {
   override fun onAttachedToWindow() {
     super.onAttachedToWindow()