-
-
Notifications
You must be signed in to change notification settings - Fork 86
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
## 📜 Description Removed replicas from the package. ## 💡 Motivation and Context Initially when I started to work on this package I thought to add replicas for iOS or Android if I can not derive values from a native code. Turned out I can actually derive them, so replicas are kind of not useful anymore. These methods were not documented anywhere, but I see that people are constantly trying to find these methods in documentation: <img width="577" alt="image" src="https://github.com/kirillzyusko/react-native-keyboard-controller/assets/22820318/1ad9b20a-2d33-40cf-9db3-5e5094826e93"> Since these methods were never a part of official API of this library - I'm removing them 😎 Also this change can be considered as optimization, because I'm removing code and thus reduce size of the package. ## 📢 Changelog <!-- High level overview of important changes --> <!-- For example: fixed status bar manipulation; added new types declarations; --> <!-- If your changes don't affect one of platform/language below - then remove this platform/language --> ### JS - removed `replicas` ## 🤔 How Has This Been Tested? Tested manually on iPhone 15 Pro and Pixel 2. ## 📝 Checklist - [x] CI successfully passed - [x] I added new mocks and corresponding unit-tests if library API was changed
- Loading branch information
1 parent
490b712
commit 7d2d0a2
Showing
16 changed files
with
2 additions
and
183 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
-532 Bytes
(98%)
e2e/kit/assets/android/e2e_emulator/DisabledKeyboardIsHidden.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-302 Bytes
(100%)
e2e/kit/assets/android/e2e_emulator/DisabledKeyboardIsShown.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-487 Bytes
(98%)
e2e/kit/assets/android/e2e_emulator/EnabledKeyboardIsHidden.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-539 Bytes
(99%)
e2e/kit/assets/android/e2e_emulator/EnabledKeyboardIsShown.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-652 Bytes
(98%)
e2e/kit/assets/android/e2e_emulator/KeyboardAnimationKeyboardIsHidden.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-1.56 KB
(98%)
e2e/kit/assets/android/e2e_emulator/KeyboardAnimationKeyboardIsShown.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-4.56 KB
(96%)
e2e/kit/assets/ios/iPhone 15 Pro/DisabledKeyboardIsHidden.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-2.79 KB
(99%)
e2e/kit/assets/ios/iPhone 15 Pro/DisabledKeyboardIsShown.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-2.75 KB
(97%)
e2e/kit/assets/ios/iPhone 15 Pro/KeyboardAnimationKeyboardIsHidden.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-2.12 KB
(99%)
e2e/kit/assets/ios/iPhone 15 Pro/KeyboardAnimationKeyboardIsShown.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.