Skip to content

Commit

Permalink
refactor: reusable TextInput protocol (#696)
Browse files Browse the repository at this point in the history 
## 📜 Description

Put `TextInput` protocol in a separate directory to highlight that it's
common protocol that can be re-used by other project files (not only
traversal group).

## 💡 Motivation and Context

In preparation for `offset` functionality of interactive keyboard I
discovered that we need to have common `UITextField` and `UITextView`
interface to be able to manage some props without additional
`if`-statements.

We already have our own `TextInput` protocol, so I thought we could
benefit from it and extend it for future functionality. The only one
thing is that now `TextInput` is associated with `traversal` group, but
since it can be re-used by other groups I thought it would be better to
move the file into its own separate group. That's what I did in this PR
🙂

## 📢 Changelog

### iOS

- move `TextInput` file from `traversal` to `protocol` group;

## 🤔 How Has This Been Tested?

Tested on CI.

## 📝 Checklist

- [x] CI successfully passed
- [x] I added new mocks and corresponding unit-tests if library API was
changed
  • Loading branch information
@kirillzyusko
kirillzyusko authored Nov 16, 2024
1 parent 1870f04 commit 4cdb619
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
16 changes: 8 additions & 8 deletions ios/KeyboardControllerNative/KeyboardControllerNative.xcodeproj/project.pbxproj
View file
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@
081006AC2C36906900578E07 /* UIScrollView.swift in Sources */ = {isa = PBXBuildFile; fileRef = 081006AB2C36906800578E07 /* UIScrollView.swift */; };
081006AD2C36906900578E07 /* UIScrollView.swift in Sources */ = {isa = PBXBuildFile; fileRef = 081006AB2C36906800578E07 /* UIScrollView.swift */; };
081006AE2C36906900578E07 /* UIScrollView.swift in Sources */ = {isa = PBXBuildFile; fileRef = 081006AB2C36906800578E07 /* UIScrollView.swift */; };
0837001E2CE8CA4F00D67BBF /* TextInput.swift in Sources */ = {isa = PBXBuildFile; fileRef = 0837001D2CE8CA4F00D67BBF /* TextInput.swift */; };
0837001F2CE8CA4F00D67BBF /* TextInput.swift in Sources */ = {isa = PBXBuildFile; fileRef = 0837001D2CE8CA4F00D67BBF /* TextInput.swift */; };
083700202CE8CA4F00D67BBF /* TextInput.swift in Sources */ = {isa = PBXBuildFile; fileRef = 0837001D2CE8CA4F00D67BBF /* TextInput.swift */; };
0850CCBA2CB49ECC000C0F8D /* SpringAnimationPerformanceTest.swift in Sources */ = {isa = PBXBuildFile; fileRef = 0850CCB92CB49ECC000C0F8D /* SpringAnimationPerformanceTest.swift */; };
0850CCC22CB49F74000C0F8D /* SpringAnimation.swift in Sources */ = {isa = PBXBuildFile; fileRef = 0850CCBF2CB49F74000C0F8D /* SpringAnimation.swift */; };
0850CCC32CB49F74000C0F8D /* SpringAnimation.swift in Sources */ = {isa = PBXBuildFile; fileRef = 0850CCBF2CB49F74000C0F8D /* SpringAnimation.swift */; };
Expand All @@ -36,9 +39,6 @@
0873ED822BB6B94B0004F3A4 /* FocusedInputHolder.swift in Sources */ = {isa = PBXBuildFile; fileRef = 0873ED7F2BB6B94B0004F3A4 /* FocusedInputHolder.swift */; };
0873ED832BB6B94B0004F3A4 /* FocusedInputHolder.swift in Sources */ = {isa = PBXBuildFile; fileRef = 0873ED7F2BB6B94B0004F3A4 /* FocusedInputHolder.swift */; };
0873ED842BB6B94B0004F3A4 /* FocusedInputHolder.swift in Sources */ = {isa = PBXBuildFile; fileRef = 0873ED7F2BB6B94B0004F3A4 /* FocusedInputHolder.swift */; };
0873ED852BB6B94B0004F3A4 /* TextInput.swift in Sources */ = {isa = PBXBuildFile; fileRef = 0873ED802BB6B94B0004F3A4 /* TextInput.swift */; };
0873ED862BB6B94B0004F3A4 /* TextInput.swift in Sources */ = {isa = PBXBuildFile; fileRef = 0873ED802BB6B94B0004F3A4 /* TextInput.swift */; };
0873ED872BB6B94B0004F3A4 /* TextInput.swift in Sources */ = {isa = PBXBuildFile; fileRef = 0873ED802BB6B94B0004F3A4 /* TextInput.swift */; };
0873ED882BB6B94B0004F3A4 /* ViewHierarchyNavigator.swift in Sources */ = {isa = PBXBuildFile; fileRef = 0873ED812BB6B94B0004F3A4 /* ViewHierarchyNavigator.swift */; };
0873ED892BB6B94B0004F3A4 /* ViewHierarchyNavigator.swift in Sources */ = {isa = PBXBuildFile; fileRef = 0873ED812BB6B94B0004F3A4 /* ViewHierarchyNavigator.swift */; };
0873ED8A2BB6B94B0004F3A4 /* ViewHierarchyNavigator.swift in Sources */ = {isa = PBXBuildFile; fileRef = 0873ED812BB6B94B0004F3A4 /* ViewHierarchyNavigator.swift */; };
Expand Down Expand Up @@ -71,6 +71,7 @@
/* Begin PBXFileReference section */
081006A72C36904E00578E07 /* UIResponder.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; name = UIResponder.swift; path = ../../extensions/UIResponder.swift; sourceTree = "<group>"; };
081006AB2C36906800578E07 /* UIScrollView.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; name = UIScrollView.swift; path = ../../extensions/UIScrollView.swift; sourceTree = "<group>"; };
0837001D2CE8CA4F00D67BBF /* TextInput.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; name = TextInput.swift; path = ../protocols/TextInput.swift; sourceTree = SOURCE_ROOT; };
0850CCB92CB49ECC000C0F8D /* SpringAnimationPerformanceTest.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = SpringAnimationPerformanceTest.swift; sourceTree = "<group>"; };
0850CCBF2CB49F74000C0F8D /* SpringAnimation.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; name = SpringAnimation.swift; path = ../../animations/SpringAnimation.swift; sourceTree = "<group>"; };
0850CCC02CB49F74000C0F8D /* KeyboardAnimation.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; name = KeyboardAnimation.swift; path = ../../animations/KeyboardAnimation.swift; sourceTree = "<group>"; };
Expand All @@ -87,7 +88,6 @@
0873ED702BB6B7390004F3A4 /* KeyboardControllerNativeUITests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = KeyboardControllerNativeUITests.swift; sourceTree = "<group>"; };
0873ED722BB6B7390004F3A4 /* KeyboardControllerNativeUITestsLaunchTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = KeyboardControllerNativeUITestsLaunchTests.swift; sourceTree = "<group>"; };
0873ED7F2BB6B94B0004F3A4 /* FocusedInputHolder.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; name = FocusedInputHolder.swift; path = ../../traversal/FocusedInputHolder.swift; sourceTree = "<group>"; };
0873ED802BB6B94B0004F3A4 /* TextInput.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; name = TextInput.swift; path = ../../traversal/TextInput.swift; sourceTree = "<group>"; };
0873ED812BB6B94B0004F3A4 /* ViewHierarchyNavigator.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; name = ViewHierarchyNavigator.swift; path = ../../traversal/ViewHierarchyNavigator.swift; sourceTree = "<group>"; };
0873ED8F2BB6B9960004F3A4 /* Extension+UIView.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = "Extension+UIView.swift"; sourceTree = "<group>"; };
08833D512CB56DB9007D4380 /* TimingAnimationPerformanceTest.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = TimingAnimationPerformanceTest.swift; sourceTree = "<group>"; };
Expand Down Expand Up @@ -142,6 +142,7 @@
0873ED542BB6B7380004F3A4 /* KeyboardControllerNative */ = {
isa = PBXGroup;
children = (
0837001D2CE8CA4F00D67BBF /* TextInput.swift */,
0850CCCB2CB4A096000C0F8D /* UIUtils.swift */,
0850CCC02CB49F74000C0F8D /* KeyboardAnimation.swift */,
0850CCBF2CB49F74000C0F8D /* SpringAnimation.swift */,
Expand All @@ -151,7 +152,6 @@
081006A72C36904E00578E07 /* UIResponder.swift */,
0873ED8F2BB6B9960004F3A4 /* Extension+UIView.swift */,
0873ED7F2BB6B94B0004F3A4 /* FocusedInputHolder.swift */,
0873ED802BB6B94B0004F3A4 /* TextInput.swift */,
0873ED812BB6B94B0004F3A4 /* ViewHierarchyNavigator.swift */,
0873ED552BB6B7380004F3A4 /* KeyboardControllerNativeApp.swift */,
0873ED572BB6B7380004F3A4 /* ContentView.swift */,
Expand Down Expand Up @@ -326,10 +326,10 @@
0873ED882BB6B94B0004F3A4 /* ViewHierarchyNavigator.swift in Sources */,
081006A82C36904E00578E07 /* UIResponder.swift in Sources */,
081006AC2C36906900578E07 /* UIScrollView.swift in Sources */,
0837001F2CE8CA4F00D67BBF /* TextInput.swift in Sources */,
0850CCC52CB49F74000C0F8D /* KeyboardAnimation.swift in Sources */,
0850CCC22CB49F74000C0F8D /* SpringAnimation.swift in Sources */,
0873ED822BB6B94B0004F3A4 /* FocusedInputHolder.swift in Sources */,
0873ED852BB6B94B0004F3A4 /* TextInput.swift in Sources */,
0850CCCC2CB4A096000C0F8D /* UIUtils.swift in Sources */,
);
runOnlyForDeploymentPostprocessing = 0;
Expand All @@ -349,9 +349,9 @@
0850CCC62CB49F74000C0F8D /* KeyboardAnimation.swift in Sources */,
0850CCC32CB49F74000C0F8D /* SpringAnimation.swift in Sources */,
081006AD2C36906900578E07 /* UIScrollView.swift in Sources */,
0873ED862BB6B94B0004F3A4 /* TextInput.swift in Sources */,
0850CCCD2CB4A096000C0F8D /* UIUtils.swift in Sources */,
08833D522CB56DB9007D4380 /* TimingAnimationPerformanceTest.swift in Sources */,
083700202CE8CA4F00D67BBF /* TextInput.swift in Sources */,
);
runOnlyForDeploymentPostprocessing = 0;
};
Expand All @@ -367,10 +367,10 @@
0873ED8A2BB6B94B0004F3A4 /* ViewHierarchyNavigator.swift in Sources */,
081006AA2C36904E00578E07 /* UIResponder.swift in Sources */,
081006AE2C36906900578E07 /* UIScrollView.swift in Sources */,
0837001E2CE8CA4F00D67BBF /* TextInput.swift in Sources */,
0850CCC72CB49F74000C0F8D /* KeyboardAnimation.swift in Sources */,
0850CCC42CB49F74000C0F8D /* SpringAnimation.swift in Sources */,
0873ED842BB6B94B0004F3A4 /* FocusedInputHolder.swift in Sources */,
0873ED872BB6B94B0004F3A4 /* TextInput.swift in Sources */,
0850CCCE2CB4A096000C0F8D /* UIUtils.swift in Sources */,
);
runOnlyForDeploymentPostprocessing = 0;
Expand Down
0 ios/traversal/TextInput.swift → ios/protocols/TextInput.swift
View file
File renamed without changes.

0 comments on commit 4cdb619

Please sign in to comment.