Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Localization: add support for german #3818

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Localization: add support for german #3818

wants to merge 3 commits into from

Conversation

SimonCarlsen
Copy link
Collaborator

@SimonCarlsen SimonCarlsen commented Feb 27, 2025 •
edited by RasmusKjeldgaard
Loading

Which issue does this PR close?

This PR closes #3798

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Are there any additional context?

Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Reminders

  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Make sure you have updated the cookbook with examples and showcases (for bug fixes, enhancements & new components).

Review

  • Determine if your changes are a fix, feature or breaking-change, and add the matching label to your PR. If it is tooling, dependency updates or similar, add ignore-for-release.
  • Do a self-review.
  • Request that the changes are code-reviewed
  • Request that the changes are UX reviewed (only necessary if your PR introduces visual changes)

When the pull request has been approved it will be merged to develop by Team Kirby.

@RasmusKjeldgaard RasmusKjeldgaard mentioned this pull request Feb 27, 2025
Closed
8 tasks
@RasmusKjeldgaard RasmusKjeldgaard changed the title Enhancement/3798 support for german language Localization: add support for german Feb 27, 2025
RasmusKjeldgaard
RasmusKjeldgaard reviewed Feb 27, 2025
View reviewed changes
Copy link
Collaborator

@RasmusKjeldgaard RasmusKjeldgaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid work!

As far as I can see, only thing left to do is adjust the layout of the docs page, as we talked about:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RasmusKjeldgaard RasmusKjeldgaard RasmusKjeldgaard left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Enhancement] - Support for German language
2 participants
@SimonCarlsen @RasmusKjeldgaard