Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Radio: Forward aria label from Kirby radio group to Ion radio group #3814

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

Fuzzy3
Copy link
Collaborator

@Fuzzy3 Fuzzy3 commented Feb 27, 2025

Which issue does this PR close?

This PR closes #3795

What is the new behavior?

Setting aria-label on kirby-radio-group will now be forwarded to the internal ion-radio-group (and removed from kirby-radio-group).

Does this PR introduce a breaking change?

  • Yes
  • No

Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Reminders

  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Make sure you have updated the cookbook with examples and showcases (for bug fixes, enhancements & new components).

Review

  • Determine if your changes are a fix, feature or breaking-change, and add the matching label to your PR. If it is tooling, dependency updates or similar, add ignore-for-release.
  • Do a self-review.
  • Request that the changes are code-reviewed
  • Request that the changes are UX reviewed (only necessary if your PR introduces visual changes)

When the pull request has been approved it will be merged to develop by Team Kirby.

@Fuzzy3 Fuzzy3 linked an issue Feb 27, 2025 that may be closed by this pull request
9 tasks
@github-actions github-actions bot temporarily deployed to pr-3795-bug-aria-label-on-kirby-radio-group-is-not-forwarded-to-ion-radio-group February 27, 2025 12:54 Inactive
Copy link
Collaborator

@RasmusKjeldgaard RasmusKjeldgaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff!

Consider adding a label to all the examples in the docs that are un-labelled, or add an Accessibility-section with an example. Or both 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] aria-label on kirby-radio-group is not forwarded to ion-radio-group
2 participants