Radio: Add border to selected radio button #3808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
Fuzzy3
commented
Feb 25, 2025
| @@ -4,7 +4,7 @@ | |||
| @use '@kirbydesign/core/src/scss/utils'; | |||
|
|
|||
| $radio-icon-size: utils.size('m'); | |||
| $radio-icon-mark-size: 60%; | |||
| $radio-icon-mark-size: 12px; | |||
There was a problem hiding this comment.
Hardcoded the 12px since the 60% was no longer resulting in 12px size marker, caused from the newly added border which effectively reduced the size of the container from 20x20px to 18x18px.
Probably should be converted to rem when adding support for font-resize
…shouldcould-have-a-border-to-improve-ui
…shouldcould-have-a-border-to-improve-ui
RasmusKjeldgaard
approved these changes
Feb 27, 2025
…shouldcould-have-a-border-to-improve-ui
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
This PR closes #3502
What is the new behavior?
Added border to selected radio buttons to comply with recent design for radio buttons. Border also added to disabled selected radio buttons.
Does this PR introduce a breaking change?
Checklist:
The following tasks should be carried out in sequence in order to follow the process of contributing correctly.
Reminders
Review
When the pull request has been approved it will be merged to
developby Team Kirby.