Kirby list by default have divider #2671
Conversation
apps/cookbook/src/app/showcase/list-showcase/list-showcase.component.html
Show resolved
Hide resolved
| }, | ||
| { | ||
| name: 'getStandAloneByProperty', | ||
| description: 'Property name to decide which items should be stand alone', |
There was a problem hiding this comment.
Maybe @mark-drastrup can help out here with a description, or at least verify that this is as it should be?
There was a problem hiding this comment.
It's basically his description from an old issue.
There was a problem hiding this comment.
Maybe it would be more clear with a description like this: A boolean property on the item that decides if the item should stand alone. Fx. if the item is {name: 'myItem', suspiciousActivity: true }, then getStandAloneByProperty would be suspiciousActivity.
There was a problem hiding this comment.
I changed over to your new description Mark :)
apps/cookbook/src/app/showcase/list-showcase/list-showcase.component.ts
Outdated
Show resolved
Hide resolved
apps/cookbook/src/app/showcase/list-showcase/list-showcase.component.ts
Outdated
Show resolved
Hide resolved
apps/cookbook/src/app/showcase/list-showcase/list-showcase.component.html
Show resolved
Hide resolved
| @@ -13,7 +13,7 @@ export const ListItemsExampleTemplate = `<kirby-list [items]="items" [showDivide | |||
| // tslint:disable-next-line | |||
| selector: 'cookbook-list-items-example', | |||
| template: ` | |||
| <kirby-page title="Items"> | |||
| <kirby-page title="Items with no dividers"> | |||
There was a problem hiding this comment.
I would prefer if we can rename the example components so items is the one with dividers, and the one used in the no dividers list will be called ListItemsNoDividersExampleComponent or whatever makes sense with the naming strategy.
There was a problem hiding this comment.
Okay I have changed that, but that caused several changes to routing module in example and etc which I changed too. But I have kept the same file name.
There was a problem hiding this comment.
I think the file name of this one should be changed too, to no-dividers.
Sorry, just think we should be consistent around this so we are not confusing ourselves down the line.
| @@ -330,7 +330,7 @@ export const routes: Routes = [ | |||
| }, | |||
| { | |||
| path: 'with-items', | |||
There was a problem hiding this comment.
path should probably be no-dividers now, and then we should just quickly verify that any references to with-items is changed too, if they exist. Hopefully they dont 🤞
…ault-have-divider
…ault-have-divider
Which issue does this PR close?
This PR closes #2670
What is the new behavior?
Kirby list by default will now have divider. To have no dividers on Kirby list you now need to set showDivider to false. Update cookbook to match with new behaviour and added API description for Kirby list.
Does this PR introduce a breaking change?
Are there any additional context?
Checklist:
The following tasks should be carried out in sequence in order to follow the process of contributing correctly.
Reminders
Review
When the pull request has been approved it will be merged to
developby Team Kirby.