Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add eslint config to enable autoformatting of HTML files on save #2554

Merged
merged 2 commits into from
Oct 24, 2022

Conversation

mark-drastrup
Copy link
Contributor

Which issue does this PR close?

This PR closes no issue.

What is the new behavior?

HTML files are automatically formatted on save.

Does this PR introduce a breaking change?

  • Yes
  • No

When the pull request has been approved it will be merged to develop by Team Kirby.

@github-actions github-actions bot temporarily deployed to pr-eslint-config October 19, 2022 19:08 Inactive
@RasmusKjeldgaard
Copy link
Collaborator

Can we consider adding this somewhere in a readme instead? I know we have the extension recommendations in code, but I feel managing vscode specific settings in git is not the best pattern. If I want my editor to behave differently in this project, settings.json would suddenly be checked in and recognize my changes, and I would have to work my way around that right?

@RasmusKjeldgaard RasmusKjeldgaard self-requested a review October 24, 2022 07:34
@mark-drastrup
Copy link
Contributor Author

mark-drastrup commented Oct 24, 2022

@RasmusKjeldgaard yeah that would be no problem :) If we do it this way, then we have 2 settings.json:

  1. Workspace settings - The file in this PR.
  2. User settings - The file that is updated if you go into preferences and change something. This file won't be checked into git.

The two files can live together side by side, but the Workspace Settings file will have precedence if the same setting is configured in both files :) https://code.visualstudio.com/docs/getstarted/settings#_settings-precedence

@RasmusKjeldgaard
Copy link
Collaborator

@RasmusKjeldgaard yeah that would be no problem :) If we do it this way, then we have 2 settings.json:

  1. Workspace settings - The file in this PR.
  2. User settings - The file that is updated if you go into preferences and change something. This file won't be checked into git.

The two files can live together side by side, but the Workspace Settings file will have precedence if the same setting is configured in both files :) https://code.visualstudio.com/docs/getstarted/settings#_settings-precedence

Good point, no harm done in including it then.

@mark-drastrup mark-drastrup merged commit bf58302 into develop Oct 24, 2022
@mark-drastrup mark-drastrup deleted the eslint-config branch October 24, 2022 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants