Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory leak in kirby-page #2519

Merged
merged 3 commits into from
Oct 5, 2022

Conversation

rsu-bankdata
Copy link
Contributor

@rsu-bankdata rsu-bankdata commented Oct 4, 2022

Which issue does this PR close?

This PR closes #2521

What is the new behavior?

kirby-page correctly removes event listeners from window.

Does this PR introduce a breaking change?

  • Yes
  • No

Are there any additional context?

Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Reminders

  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Make sure you have updated the cookbook with examples and showcases (for bug fixes, enhancements & new components).

Review

  • Do a self-review.
  • Request that the changes are code-reviewed
  • Request that the changes are UX reviewed (only necessary if your PR introduces visual changes)

When the pull request has been approved it will be merged to develop by Team Kirby.

@RasmusKjeldgaard RasmusKjeldgaard self-requested a review October 4, 2022 14:35
Copy link
Collaborator

@RasmusKjeldgaard RasmusKjeldgaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@RasmusKjeldgaard RasmusKjeldgaard merged commit e4e52b6 into kirbydesign:develop Oct 5, 2022
@rsu-bankdata rsu-bankdata deleted the fix/page-leak branch October 5, 2022 19:06
@jkaltoft jkaltoft mentioned this pull request Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Kirby Page memory leak
2 participants