Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug: toggles inside Kirby item placed too high #2518

Merged

Conversation

AgreSanGit
Copy link
Contributor

Which issue does this PR close?

This PR closes #2441

What is the new behavior?

Fixed the gap between ion-toggle and kirby-toggle, that occurred since the ion-toggle behaved as an inline element. The new behavior is making kirby-toggle display inline-flex, which eliminates the gap without changing the outwards behaviour of kirby toggle.

Does this PR introduce a breaking change?

  • Yes
  • No

Are there any additional context?

Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Reminders

  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Make sure you have updated the cookbook with examples and showcases (for bug fixes, enhancements & new components).

Review

  • Do a self-review.
  • Request that the changes are code-reviewed
  • Request that the changes are UX reviewed (only necessary if your PR introduces visual changes)

When the pull request has been approved it will be merged to develop by Team Kirby.

@github-actions github-actions bot temporarily deployed to pr-2441-toggles-inside-kirby-item-are-placed-too-high October 4, 2022 08:16 Inactive
@AgreSanGit AgreSanGit marked this pull request as ready for review October 4, 2022 08:22
@AgreSanGit AgreSanGit requested a review from jkaltoft as a code owner October 4, 2022 08:22
Copy link
Collaborator

@jkaltoft jkaltoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 😎

I think you should change the PR title before merging. "Add display inline-flex on kirby toggle" is a bit too implementation specific. It should say something about which bug the PR fixes. Keep in mind, that it ends up in the changelog.

@AgreSanGit AgreSanGit changed the title Add display inline-flex on kirby toggle Fixed bug: toggles inside Kirby item placed too high Oct 4, 2022
@AgreSanGit AgreSanGit merged commit 1b00cf6 into develop Oct 4, 2022
@AgreSanGit AgreSanGit deleted the bug/2441-toggles-inside-kirby-item-are-placed-too-high branch October 4, 2022 09:05
@jkaltoft jkaltoft mentioned this pull request Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Toggles inside kirby-item are placed too high
2 participants