Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List sub sections #2478

Merged
merged 32 commits into from
Sep 27, 2022
Merged

List sub sections #2478

merged 32 commits into from
Sep 27, 2022

Conversation

mark-drastrup
Copy link
Contributor

@mark-drastrup mark-drastrup commented Sep 14, 2022

Which issue does this PR close?

This PR closes #1604

What is the new behavior?

Makes it possible to create sub sections / stand alone items in both normal lists and lists with sections.

Does this PR introduce a breaking change?

  • Yes
  • No

Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Reminders

  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Make sure you have updated the cookbook with examples and showcases (for bug fixes, enhancements & new components).

Review

  • Do a self-review.
  • Request that the changes are code-reviewed
  • Request that the changes are UX reviewed (only necessary if your PR introduces visual changes)

When the pull request has been approved it will be merged to develop by Team Kirby.

@mark-drastrup mark-drastrup marked this pull request as draft September 14, 2022 14:41
@github-actions github-actions bot temporarily deployed to pr-1604-list-sub-sections September 15, 2022 08:01 Inactive
@mark-drastrup mark-drastrup marked this pull request as ready for review September 16, 2022 14:29
@github-actions github-actions bot temporarily deployed to pr-1604-list-sub-sections September 16, 2022 14:36 Inactive
@github-actions github-actions bot temporarily deployed to pr-1604-list-sub-sections September 19, 2022 07:16 Inactive
@github-actions github-actions bot temporarily deployed to pr-1604-list-sub-sections September 20, 2022 12:45 Inactive
@github-actions github-actions bot temporarily deployed to pr-1604-list-sub-sections September 26, 2022 12:11 Inactive
@github-actions github-actions bot temporarily deployed to pr-1604-list-sub-sections September 27, 2022 12:58 Inactive
Copy link
Collaborator

@jkaltoft jkaltoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Just a single thing left 🙂

Copy link
Collaborator

@jkaltoft jkaltoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like something is broken in the "List with sections" example:

image

@mark-drastrup
Copy link
Contributor Author

It looks like something is broken in the "List with sections" example:

image

@jkaltoft are you still experiencing this issue? I cannot replicate it locally or on the deployment 🤔

@jkaltoft
Copy link
Collaborator

It looks like something is broken in the "List with sections" example:

@jkaltoft are you still experiencing this issue? I cannot replicate it locally or on the deployment 🤔

No, it looks alright now 🤷‍♂️

Copy link
Collaborator

@jkaltoft jkaltoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're finally there 🎉🥳

giphub

@mark-drastrup mark-drastrup merged commit 2169ce6 into develop Sep 27, 2022
@mark-drastrup mark-drastrup deleted the enhancement/1604-list-sub-sections branch September 27, 2022 14:05
@jkaltoft jkaltoft mentioned this pull request Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] List sub sections
3 participants