Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Highlight color remains both when the accordion is expanded and after it gets collapsed again #2458

Merged
merged 1 commit into from
Sep 8, 2022
Merged

Highlight color remains both when the accordion is expanded and after it gets collapsed again #2458

merged 1 commit into from
Sep 8, 2022

Conversation

mictro
Copy link
Contributor

@mictro mictro commented Sep 6, 2022 •
edited by jkaltoft
Loading

Which issue does this PR close?

This PR closes #2453

What is the new behavior?

Remove persistent hightlight-color during expand collapse.

Does this PR introduce a breaking change?

  • Yes
  • No

Are there any additional context?

Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Reminders

  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Make sure you have updated the cookbook with examples and showcases (for bug fixes, enhancements & new components).

Review

  • Do a self-review.
  • Request that the changes are code-reviewed
  • Request that the changes are UX reviewed (only necessary if your PR introduces visual changes)

When the pull request has been approved it will be merged to develop by Team Kirby.

@mictro mictro requested a review from jkaltoft as a code owner September 6, 2022 10:13
@mictro mictro changed the base branch from develop to release/v7.0.0 September 6, 2022 10:14
jkaltoft
jkaltoft approved these changes Sep 6, 2022
View reviewed changes
Copy link
Collaborator

@jkaltoft jkaltoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

Don't forget to link the issue and the PR. Also update the PR title before merging.

@mictro mictro linked an issue Sep 7, 2022 that may be closed by this pull request
[BUG] Accordion: Highlight color remains both when the accordion is expanded and after it gets collapsed again #2453
Closed
@mictro mictro merged commit 6079692 into release/v7.0.0 Sep 8, 2022
@mictro mictro deleted the bug/2453-highlight-color-remains-both-when-the-accordion-is-expanded-and-after-it-gets-collapsed-again branch September 8, 2022 06:21
@mictro mictro changed the title Bug/2453 highlight color remains both when the accordion is expanded and after it gets collapsed again Highlight color remains both when the accordion is expanded and after it gets collapsed again Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkaltoft jkaltoft jkaltoft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Accordion: Highlight color remains both when the accordion is expanded and after it gets collapsed again
2 participants
@mictro @jkaltoft