Missing close icon in FAB-sheet #2403
Merged
+14
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
This PR closes #2402
What is the new behavior?
The housekeeping done in #2302 only worked in the cookbook because we have ionicons installed which meant that the ion-fab-button could correctly locate the close icon. Projects should not have to install Ionicons, so this PR introduces a workaround where we place our own close icon where ion-fab-button expects it to be.
Therefore, the custom close icon introduced in #2302 is removed again, and a description of how to place the existing close icon as needed is added instead.
This is already how it is done in the DRB project, so it solves the problem described in #2402. With this fix installed, we now get the following close icon:
Screen.Recording.2022-08-03.at.13.02.01.mov
Does this PR introduce a breaking change?
Checklist:
The following tasks should be carried out in sequence in order to follow the process of contributing correctly.
Reminders
Review
When the pull request has been approved it will be merged to
develop
by Team Kirby.