Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing close icon in FAB-sheet #2403

Merged
merged 2 commits into from
Aug 3, 2022

Conversation

RasmusKjeldgaard
Copy link
Collaborator

@RasmusKjeldgaard RasmusKjeldgaard commented Aug 2, 2022

Which issue does this PR close?

This PR closes #2402

What is the new behavior?

The housekeeping done in #2302 only worked in the cookbook because we have ionicons installed which meant that the ion-fab-button could correctly locate the close icon. Projects should not have to install Ionicons, so this PR introduces a workaround where we place our own close icon where ion-fab-button expects it to be.

Therefore, the custom close icon introduced in #2302 is removed again, and a description of how to place the existing close icon as needed is added instead.

This is already how it is done in the DRB project, so it solves the problem described in #2402. With this fix installed, we now get the following close icon:

Screen.Recording.2022-08-03.at.13.02.01.mov

Does this PR introduce a breaking change?

  • Yes
  • No

Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Reminders

  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Make sure you have updated the cookbook with examples and showcases (for bug fixes, enhancements & new components).

Review

  • Do a self-review.
  • Request that the changes are code-reviewed
  • Request that the changes are UX reviewed (only necessary if your PR introduces visual changes)

When the pull request has been approved it will be merged to develop by Team Kirby.

@RasmusKjeldgaard RasmusKjeldgaard changed the title Bug/2402 fab sheet missing close icon Missing close icon in FAB-sheet Aug 2, 2022
@RasmusKjeldgaard RasmusKjeldgaard merged commit 3d9a6b1 into develop Aug 3, 2022
@RasmusKjeldgaard RasmusKjeldgaard deleted the bug/2402-fab-sheet-missing-close-icon branch August 3, 2022 11:07
This was referenced Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Missing close icon on fab-sheet
2 participants