Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing fab-sheet backdrop on mobile devices #2401

Conversation

mictro
Copy link
Contributor

@mictro mictro commented Aug 2, 2022

Which issue does this PR close?

This PR closes #2398

What is the new behavior?

Fab sets backdrop on mobile devices.

Does this PR introduce a breaking change?

  • Yes
  • No

Are there any additional context?

Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Reminders

  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Make sure you have updated the cookbook with examples and showcases (for bug fixes, enhancements & new components).

Review

  • Do a self-review.
  • Request that the changes are code-reviewed
  • Request that the changes are UX reviewed (only necessary if your PR introduces visual changes)

When the pull request has been approved it will be merged to develop by Team Kirby.

@mictro mictro linked an issue Aug 2, 2022 that may be closed by this pull request
9 tasks
@mictro mictro requested a review from RasmusKjeldgaard August 2, 2022 09:25
@mictro mictro changed the title Fix missing backdrop on mobile Fix missing backdrop on mobile devices Aug 2, 2022
@mictro mictro changed the title Fix missing backdrop on mobile devices Fix missing fab-sheet backdrop on mobile devices Aug 2, 2022
@github-actions github-actions bot temporarily deployed to pr-2398-komponenten-kirby-fab-sheet-s-tter-ikke-backdrop-p-mobil August 2, 2022 09:30 Inactive
@RasmusKjeldgaard
Copy link
Collaborator

@mictro consider extending the 'What is the new behavior?' section with a description of what the problem with the existing code was, and why the setTimeout is no longer needed etc. Both for future us, and so I can better understand why this change does not break anything 😁

Copy link
Collaborator

@RasmusKjeldgaard RasmusKjeldgaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like the opacity transition (fade-in effect) is no longer working for the backdrop with this change.

The setTimeout was probably there to make sure that the backdrop-visible class was added to task queue as a new task, and therefore would happen after the backdrop was already in the DOM, so the transition is applied.

@mictro mictro force-pushed the bug/2398-komponenten-kirby-fab-sheet-sætter-ikke-backdrop-på-mobil branch from 7cffe13 to 15d778d Compare August 4, 2022 12:01
@mictro
Copy link
Contributor Author

mictro commented Aug 4, 2022

Oops, timeout reintroduced and opacity animation is now visible.

@mictro mictro requested a review from RasmusKjeldgaard August 4, 2022 12:06
@github-actions github-actions bot temporarily deployed to pr-2398-komponenten-kirby-fab-sheet-s-tter-ikke-backdrop-p-mobil August 4, 2022 12:06 Inactive
@mictro mictro merged commit eda1753 into develop Aug 5, 2022
@mictro mictro deleted the bug/2398-komponenten-kirby-fab-sheet-sætter-ikke-backdrop-på-mobil branch August 5, 2022 05:01
This was referenced Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Komponenten kirby-fab-sheet sætter ikke backdrop på mobil
2 participants