Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid removing focus from Segmented Control on embedded badge click #2400

Merged
merged 1 commit into from
Aug 4, 2022

Conversation

RasmusKjeldgaard
Copy link
Collaborator

@RasmusKjeldgaard RasmusKjeldgaard commented Aug 1, 2022

Which issue does this PR close?

closes #2388 closes #2349

What is the new behavior?

I have refactored the wrapper click prevention to instead determine if the click is coming from the ion-segment-button or its contents. This should exclude both the wrapper, and also other elements like the badge.

Does this PR introduce a breaking change?

  • Yes
  • No

Are there any additional context?

Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Reminders

  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Make sure you have updated the cookbook with examples and showcases (for bug fixes, enhancements & new components).

Review

  • Do a self-review.
  • Request that the changes are code-reviewed
  • Request that the changes are UX reviewed (only necessary if your PR introduces visual changes)

When the pull request has been approved it will be merged to develop by Team Kirby.

@github-actions github-actions bot temporarily deployed to pr-2388-badge-click-removes-focus August 1, 2022 14:30 Inactive
@jkaltoft jkaltoft self-requested a review August 4, 2022 09:26
Copy link
Collaborator

@jkaltoft jkaltoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RasmusKjeldgaard RasmusKjeldgaard force-pushed the bug/2388-badge-click-removes-focus branch from 7e2df12 to f9ab6bb Compare August 4, 2022 10:04
@RasmusKjeldgaard RasmusKjeldgaard merged commit 78f8cad into develop Aug 4, 2022
@RasmusKjeldgaard RasmusKjeldgaard deleted the bug/2388-badge-click-removes-focus branch August 4, 2022 11:45
This was referenced Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants