-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Short term fix for input field styles #2314
Conversation
Use relative sizes and unitless line height
libs/designsystem/src/lib/components/form-field/_form-field-inputs.shared.scss
Outdated
Show resolved
Hide resolved
Co-authored-by: Michael T <micbittro@gmail.com>
libs/designsystem/src/lib/components/form-field/input/input.component.integration.spec.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the changes are good, as they fix the issue. I am a bit concerned that it will be a long time before we have the size refactoring in place, and until then these changes does not really make sense on their own, as we are breaking away from our existing tokens.
I agree. I'm also a bit concerned. On the other hand, this is a "web/desktop ready" related thing, and as far as I know that is still a high priority epic. I suggest we push for getting #2313 prioritized and refined. |
Which issue does this PR close?
This PR closes #2301
What is the new behavior?
Fixes visual bug: Mask/placeholder and input text has wrong position (size
md
)At unchanged base font size there should be no visual changes. Otherwise improvement by scaling sizes properly relative to base font size.
Does this PR introduce a breaking change?
But UX review should try to verify that there are no visual regressions introduced.
Are there any additional context?
Before
After
Checklist:
The following tasks should be carried out in sequence in order to follow the process of contributing correctly.
Reminders
Make sure you have implemented tests following the guidelines in: "The good: Test".Make sure you have updated the cookbook with examples and showcases (for bug fixes, enhancements & new components).Review
When the pull request has been approved it will be merged to
develop
by Team Kirby.