Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Short term fix for input field styles #2314

Merged
merged 7 commits into from
Jun 9, 2022

Conversation

jkaltoft
Copy link
Collaborator

@jkaltoft jkaltoft commented Jun 7, 2022

Which issue does this PR close?

This PR closes #2301

What is the new behavior?

Fixes visual bug: Mask/placeholder and input text has wrong position (size md)

At unchanged base font size there should be no visual changes. Otherwise improvement by scaling sizes properly relative to base font size.

Does this PR introduce a breaking change?

  • Yes
  • No

But UX review should try to verify that there are no visual regressions introduced.

Are there any additional context?

Before

image

After

image

Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Reminders

  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Make sure you have updated the cookbook with examples and showcases (for bug fixes, enhancements & new components).

Review

  • Do a self-review.
  • Request that the changes are code-reviewed
  • Request that the changes are UX reviewed (only necessary if your PR introduces visual changes)

When the pull request has been approved it will be merged to develop by Team Kirby.

@github-actions github-actions bot temporarily deployed to pr-2301-quickfix-for-input-field-styles June 8, 2022 09:27 Inactive
@github-actions github-actions bot temporarily deployed to pr-2301-quickfix-for-input-field-styles June 8, 2022 09:41 Inactive
@github-actions github-actions bot temporarily deployed to pr-2301-quickfix-for-input-field-styles June 8, 2022 11:44 Inactive
@mictro mictro self-requested a review June 8, 2022 11:51
Co-authored-by: Michael T <micbittro@gmail.com>
Copy link
Collaborator

@RasmusKjeldgaard RasmusKjeldgaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the changes are good, as they fix the issue. I am a bit concerned that it will be a long time before we have the size refactoring in place, and until then these changes does not really make sense on their own, as we are breaking away from our existing tokens.

@jkaltoft
Copy link
Collaborator Author

jkaltoft commented Jun 9, 2022

I think the changes are good, as they fix the issue. I am a bit concerned that it will be a long time before we have the size refactoring in place, and until then these changes does not really make sense on their own, as we are breaking away from our existing tokens.

I agree. I'm also a bit concerned. On the other hand, this is a "web/desktop ready" related thing, and as far as I know that is still a high priority epic.

I suggest we push for getting #2313 prioritized and refined.

@jkaltoft jkaltoft merged commit 126e939 into develop Jun 9, 2022
@jkaltoft jkaltoft deleted the bug/2301-quickfix-for-input-field-styles branch June 9, 2022 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] medium sized date type inputfield layout error
3 participants