Active state for ionic components and special cases #2207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Active state should not be overwritable. If item is selectable we want to make sure it has active state.
Some custom functionality for hover was also rewritten to use existing util function get-state-color.
acfea4f
into
release/theme/interaction-states-and-attention-levels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
This PR closes #2197 fixes #2198
What is the new behavior?
An ionic-specific mixin has been created for those of ionics components that use the
--background-activatedand--background-activated-opacityapproach.Unfortunately that is not the case for all Ionics components so custom approaches has been implemented for those and some of our non-ionic based components.
Does this PR introduce a breaking change?
Active state should not be overwritten for selectable items, it should follow the same conventions as any other component. If item has
selectable="true"we want to make sure it has the appropriate active state.For most, migration should be fairly simple - just remove
--kirby-item-background-activated-related CSS.Checklist:
The following tasks should be carried out in sequence in order to follow the process of contributing correctly.
Review
When the pull request has been approved it will be automatically merged to
stablevia automerge.