Change state layer 'flip' argument to 'make-lighter' #2188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkaltoft
approved these changes
Apr 25, 2022
Base automatically changed from
enhancement/2135-move-shared-functionality-to-utilities-partial
to
release/theme/interaction-states-and-attention-levels
April 27, 2022 14:48
8091d48 to
ecc5462
Compare
ecc5462 to
0b1d642
Compare
38207ac
into
release/theme/interaction-states-and-attention-levels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
This PR closes #2136
What is the new behavior?
$flipis now$make-lighterinapply-state().Does this PR introduce a breaking change?
Checklist:
The following tasks should be carried out in sequence in order to follow the process of contributing correctly.
Reminders
Make sure you have implemented tests following the guidelines in: "The good: Test".Make sure you have updated the cookbook with examples and showcases (for bug fixes, enhancements & new components).Review
Request that the changes are UX reviewed (only necessary if your PR introduces visual changes)When the pull request has been approved it will be automatically merged to
stablevia automerge.