Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interaction state hover for accordion #2138

Conversation

RasmusKjeldgaard
Copy link
Collaborator

Which issue does this PR close?

This PR closes #2089

What is the new behavior?

Hover background styles are applied when hovering the whole item, also when expanded.
The cursor is only a pointer when hovering over the header, as it is only the header that is interactive.

Does this PR introduce a breaking change?

  • Yes
  • No

Are there any additional context?

Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Reminders

  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Make sure you have updated the cookbook with examples and showcases (for bug fixes, enhancements & new components).

Review

  • Do a self-review.
  • Request that the changes are code-reviewed
  • Request that the changes are UX reviewed (only necessary if your PR introduces visual changes)

When the pull request has been approved it will be automatically merged to stable via automerge.

@RasmusKjeldgaard RasmusKjeldgaard changed the base branch from main to release/theme/2028-button-attention-levels-and-hover March 28, 2022 07:53
@RasmusKjeldgaard RasmusKjeldgaard merged commit bfb85c3 into release/theme/2028-button-attention-levels-and-hover Mar 28, 2022
@RasmusKjeldgaard RasmusKjeldgaard deleted the enhancement/2089-interaction-state-hover-for-accordion branch March 28, 2022 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interaction State Hover for Accordion
2 participants