Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interaction state for toggle #2133

Conversation

jkaltoft
Copy link
Collaborator

Which issue does this PR close?

This PR closes #2058

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Are there any additional context?

Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Reminders

  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Make sure you have updated the cookbook with examples and showcases (for bug fixes, enhancements & new components).

Review

  • Do a self-review.
  • Request that the changes are code-reviewed
  • Request that the changes are UX reviewed (only necessary if your PR introduces visual changes)

When the pull request has been approved it will be automatically merged to stable via automerge.

@RasmusKjeldgaard
Copy link
Collaborator

Awesome with the updated design as well. Should we update the knob's box shadow too, so this PR closes #2088 altogether?

@jkaltoft jkaltoft merged commit d479ffa into release/theme/2028-button-attention-levels-and-hover Mar 28, 2022
@jkaltoft jkaltoft deleted the enhancement/2058-interaction-state-for-toggle branch March 28, 2022 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants