Interaction state hover for radio button #2128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkaltoft
commented
Mar 24, 2022
libs/designsystem/src/lib/components/radio/radio.component.scss
Outdated
Show resolved
Hide resolved
7 tasks
|
@jkaltoft there are testing errors in relation to the radio group. They seem related to these changes. |
jkaltoft
added a commit
that referenced
this pull request
Mar 25, 2022
#2128 also needs to calculate color in the exact same way
jkaltoft
added a commit
that referenced
this pull request
Mar 25, 2022
* 💄 Add function that calculates hover color * 💄 Apply transition * ♻️ 💄 Move helper function to shared location #2128 also needs to calculate color in the exact same way
Allow list of multiple properties as argument
ec96b35 to
6233666
Compare
RasmusKjeldgaard
approved these changes
Mar 25, 2022
9f34681
into
release/theme/2028-button-attention-levels-and-hover
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
This PR closes #2091
What is the new behavior?
Does this PR introduce a breaking change?
Are there any additional context?
Checklist:
The following tasks should be carried out in sequence in order to follow the process of contributing correctly.
Reminders
Review
When the pull request has been approved it will be automatically merged to
stablevia automerge.