Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hover solution for non solid backgrounds in card #2123

Merged
merged 4 commits into from
Mar 28, 2022
Merged

Hover solution for non solid backgrounds in card #2123

merged 4 commits into from
Mar 28, 2022

Conversation

jkaltoft
Copy link
Collaborator

@jkaltoft jkaltoft commented Mar 23, 2022 •
edited
Loading

Which issue does this PR close?

This PR closes #2006

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Are there any additional context?

Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Reminders

  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Make sure you have updated the cookbook with examples and showcases (for bug fixes, enhancements & new components).

Review

  • Do a self-review.
  • Request that the changes are code-reviewed
  • Request that the changes are UX reviewed (only necessary if your PR introduces visual changes)

When the pull request has been approved it will be automatically merged to stable via automerge.

@jkaltoft jkaltoft force-pushed the enhancement/2006-hover-solution-for-non-solid-backgrounds-in-card branch from b5af2cf to a06f3ff Compare March 25, 2022 13:41
@jkaltoft jkaltoft force-pushed the enhancement/2006-hover-solution-for-non-solid-backgrounds-in-card branch from a06f3ff to c320611 Compare March 25, 2022 13:44
@jkaltoft jkaltoft merged commit 7e42132 into release/theme/2028-button-attention-levels-and-hover Mar 28, 2022
@jkaltoft jkaltoft deleted the enhancement/2006-hover-solution-for-non-solid-backgrounds-in-card branch March 28, 2022 08:16
@RasmusKjeldgaard RasmusKjeldgaard linked an issue Apr 5, 2022 that may be closed by this pull request
Create hover solution for non-solid backgrounds in card (pseudo element and opacity) #2006
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RasmusKjeldgaard RasmusKjeldgaard RasmusKjeldgaard approved these changes

Assignees
No one assigned
Labels
🧑‍🎨 Needs UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create hover solution for non-solid backgrounds in card (pseudo element and opacity)
2 participants
@jkaltoft @RasmusKjeldgaard