Skip to content

Commit

Permalink
Range: Fix undefined pinFormatter on initialization (#3367)
Browse files Browse the repository at this point in the history
  • Loading branch information
RasmusKjeldgaard authored Feb 6, 2024
1 parent d0b599e commit 8faaa25
Show file tree
Hide file tree
Showing 2 changed files with 30 additions and 1 deletion.
25 changes: 25 additions & 0 deletions libs/designsystem/range/src/range.component.spec.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
import { createHostFactory, SpectatorHost } from '@ngneat/spectator';
import { TestHelper } from '@kirbydesign/designsystem/testing';
import { RangeComponent } from './range.component';

describe('RangeComponent', () => {
let spectator: SpectatorHost<RangeComponent>;

const createHost = createHostFactory({
component: RangeComponent,
imports: [TestHelper.ionicModuleForTest],
});

beforeEach(() => {
spectator = createHost('<kirby-range></kirby-range>');
});

it('should create', () => {
expect(spectator.component).toBeTruthy();
});

it('should always have a pinFormatter function when pin is set', () => {
spectator.setInput('pin', true);
expect(spectator.component.pinFormatter).toBeDefined();
});
});
6 changes: 5 additions & 1 deletion libs/designsystem/range/src/range.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ export class RangeComponent implements OnChanges, OnInit, ControlValueAccessor {
@Input() step = 1;
@Input() ticks: boolean;
@Input() disabled = false;
@Input() pinFormatter: (value: number) => string | number;
@Input() pinFormatter: (value: number) => string | number = this.defaultPinFormatter;
@Input()
set value(value: number) {
if (value !== this.currentValue) {
Expand Down Expand Up @@ -99,6 +99,10 @@ export class RangeComponent implements OnChanges, OnInit, ControlValueAccessor {
}
}

private defaultPinFormatter(value: number): number {
return value;
}

public setDisabledState?(isDisabled: boolean): void {
this.disabled = isDisabled;
}
Expand Down

0 comments on commit 8faaa25

Please sign in to comment.