Remove Standalone for ListItemTemplateDirective

kirbydesign · Feb 3, 2025 · 09d4713 · 09d4713
1 parent b8b289c
commit 09d4713
Show file tree

Hide file tree

Showing 6 changed files with 14 additions and 9 deletions.
diff --git a/libs/designsystem/dropdown/src/dropdown-popover.component.spec.ts b/libs/designsystem/dropdown/src/dropdown-popover.component.spec.ts
@@ -889,9 +889,9 @@ describe('DropdownComponent (popover version)', () => {
 
     const createHost = createHostFactory({
       component: DropdownComponent,
-      imports: [ListItemTemplateDirective],
       declarations: [
         ItemComponent,
+        ListItemTemplateDirective,
         MockComponents(ButtonComponent, CardComponent, IconComponent, IonItem, PopoverComponent),
       ],
     });

diff --git a/libs/designsystem/dropdown/src/dropdown.component.spec.ts b/libs/designsystem/dropdown/src/dropdown.component.spec.ts
@@ -1009,9 +1009,9 @@ describe('DropdownComponent', () => {
 
     const createHost = createHostFactory({
       component: DropdownComponent,
-      imports: [ListItemTemplateDirective],
       declarations: [
         ItemComponent,
+        ListItemTemplateDirective,
         MockComponents(ButtonComponent, CardComponent, IconComponent, IonItem, PopoverComponent),
       ],
     });

diff --git a/libs/designsystem/list/src/list.component.integration.spec.ts b/libs/designsystem/list/src/list.component.integration.spec.ts
@@ -26,7 +26,7 @@ describe('ListComponent', () => {
   let spectator: SpectatorHost<ListComponent>;
   const createHost = createHostFactory({
     component: ListComponent,
-    imports: [TestHelper.ionicModuleForTest, CardModule, SpinnerModule, ListItemTemplateDirective],
+    imports: [TestHelper.ionicModuleForTest, CardModule, SpinnerModule],
     providers: [
       {
         provide: WindowRef,
@@ -38,6 +38,7 @@ describe('ListComponent', () => {
       IconComponent,
       InfiniteScrollDirective,
       ListItemColorDirective,
+      ListItemTemplateDirective,
       ListItemComponent,
     ],
   });

diff --git a/libs/designsystem/list/src/list.directive.ts b/libs/designsystem/list/src/list.directive.ts
@@ -2,7 +2,7 @@ import { Directive } from '@angular/core';
 
 @Directive({
   selector: '[kirbyListItemTemplate]',
-  standalone: true,
+  standalone: false,
 })
 export class ListItemTemplateDirective {}
 

diff --git a/libs/designsystem/list/src/list.module.ts b/libs/designsystem/list/src/list.module.ts
@@ -30,6 +30,7 @@ import {
 const exportedDeclarations = [
   ListComponent,
   ListItemComponent,
+  ListItemTemplateDirective,
   ListSectionHeaderComponent,
   ListSectionHeaderDirective,
   ListHeaderDirective,
@@ -38,7 +39,12 @@ const exportedDeclarations = [
   ListExperimentalComponent,
 ];
 
-const declarations = [...exportedDeclarations, ListItemColorDirective, InfiniteScrollDirective];
+const declarations = [
+  ...exportedDeclarations,
+  ListItemColorDirective,
+  InfiniteScrollDirective,
+  ListItemComponent,
+];
 
 @NgModule({
   declarations: declarations,
@@ -53,9 +59,8 @@ const declarations = [...exportedDeclarations, ListItemColorDirective, InfiniteS
     IonLabel,
     IonList,
     IonListHeader,
-    ListItemTemplateDirective,
   ],
-  exports: [exportedDeclarations, ListItemTemplateDirective],
+  exports: [exportedDeclarations],
   providers: [],
 })
 export class ListModule {}
diff --git a/libs/designsystem/radio/src/radio-group/radio-group.component.spec.ts b/libs/designsystem/radio/src/radio-group/radio-group.component.spec.ts
@@ -23,15 +23,14 @@ const { getColor } = DesignTokenHelper;
 describe('RadioGroupComponent', () => {
   const createHost = createHostFactory({
     component: RadioGroupComponent,
-    declarations: [RadioComponent],
+    declarations: [RadioComponent, ListItemTemplateDirective],
     imports: [
       TestHelper.ionicModuleForTest,
       IonRadioGroup,
       IonRadio,
       FormsModule,
       ReactiveFormsModule,
       FlagComponent,
-      ListItemTemplateDirective,
     ],
   });