Skip to content
This repository has been archived by the owner on Jun 29, 2022. It is now read-only.

go.mod: update dependencies to their latest versions. #780

Closed
wants to merge 1 commit into from

Conversation

ipochi
Copy link
Member

@ipochi ipochi commented Aug 10, 2020

Signed-off-by: Imran Pochi imran@kinvolk.io

@ipochi ipochi requested review from surajssd, invidian and knrt10 August 10, 2020 09:26
@ipochi ipochi requested a review from johananl as a code owner August 10, 2020 09:26
invidian
invidian previously approved these changes Aug 10, 2020
@ipochi
Copy link
Member Author

ipochi commented Aug 10, 2020

make
GO111MODULE=on go generate -mod=vendor ./...
CGO_ENABLED=0 GO111MODULE=on go build \
	-mod=vendor \
	-ldflags "-X github.com/kinvolk/lokomotive/pkg/version.Version=`git describe --tags --always` -extldflags '-static'" \
	-buildmode=exe \
	-o lokoctl \
	github.com/kinvolk/lokomotive/cmd/lokoctl
# sigs.k8s.io/kustomize/pkg/transformers/config
vendor/sigs.k8s.io/kustomize/pkg/transformers/config/factorycrd.go:71:47: cannot use api.Schema.SchemaProps.Properties (type spec.SchemaProperties) as type myProperties in argument to looksLikeAk8sType
make: *** [Makefile:52: build-slim] Error 2

@ipochi ipochi dismissed invidian’s stale review August 10, 2020 10:11

Does not build. Will look into it.

Signed-off-by: Imran Pochi <imran@kinvolk.io>
@ipochi ipochi force-pushed the imran/update-dependencies branch from 372a939 to b7e9a8f Compare August 10, 2020 10:42
@ipochi ipochi requested a review from invidian August 10, 2020 10:43
Copy link
Member

@invidian invidian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After running go get -u ./... on this PR (as make update is broken), I get following error:

go: finding module for package github.com/googleapis/gnostic/OpenAPIv2
../../../go/pkg/mod/k8s.io/client-go@v11.0.0+incompatible/discovery/discovery_client.go:29:2: module github.com/googleapis/gnostic@latest found (v0.5.1), but does not contain package github.com/googleapis/gnostic/OpenAPIv2

It seems the dependencies were not properly updated?

@ipochi
Copy link
Member Author

ipochi commented Aug 10, 2020

Updating the dependencies causes issues
This will be addressed on Kubernetes 1.19 is out.

@ipochi ipochi closed this Aug 10, 2020
@surajssd
Copy link
Member

@ipochi should we keep the branch around?

@ipochi ipochi deleted the imran/update-dependencies branch August 11, 2020 10:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants