Upgrade imports to supported python versions #600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also see no reason why this should not be bumped to 3.10, the latest versions of numpy do not support 3.9. |
kinverarity1
approved these changes
Mar 22, 2025
|
Thank you very much @frank1010111 and apologies for the delay in merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.9 is the lowest supported Python version. In this code, I've changed the imports to follow ruff's isort rules and remove the dance required for supporting Python 2 and Python 3 less than 3.9.
The unit tests pass on my local linux machine.
Hope this helps.