Let’s try matrix again

kingstinct · Jul 24, 2023 · 82a547e · 82a547e
1 parent 82d112d
commit 82a547e
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 17 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -20,9 +20,9 @@ jobs:
     # The type of runner that the job will run on
     runs-on: ubuntu-latest
     timeout-minutes: 10
-    # strategy:
-    #   matrix:
-    #     node-version: [ 16.x, 18.x, 20.x ]
+    strategy:
+      matrix:
+        node-version: [ 16.x, 18.x, 20.x ]
     env:
       ACTIONS_ALLOW_UNSECURE_COMMANDS: true
 
@@ -39,10 +39,9 @@ jobs:
         id: setup
         with:
           cache: pnpm
-          node-version-file: .nvmrc
+          node-version: ${{ matrix.node-version }}
 
       - name: Install deps
-        id: install
         if: ${{ steps.setup.outputs.cache-hit != 'true' }}
         run: pnpm install --frozen-lockfile
 
@@ -70,7 +69,7 @@ jobs:
   #       id: setup
   #       with:
   #         cache: pnpm
-  #         node-version-file: .nvmrc
+  #         node-
 
   #     - name: Install deps
   #       id: install
@@ -84,9 +83,9 @@ jobs:
     runs-on: ubuntu-latest
     timeout-minutes: 10
     needs: cache-warmer
-    # strategy:
-    #   matrix:
-    #     node-version: [ 16.x, 18.x, 20.x ]
+    strategy:
+      matrix:
+        node-version: [ 16.x, 18.x, 20.x ]
     env:
       ACTIONS_ALLOW_UNSECURE_COMMANDS: true
 
@@ -103,10 +102,9 @@ jobs:
         id: setup
         with:
           cache: pnpm
-          node-version-file: .nvmrc
+          node-version: ${{ matrix.node-version }}
 
       - name: Install deps
-        id: install
         run: pnpm install --frozen-lockfile
 
       - name: Typecheck
@@ -117,9 +115,9 @@ jobs:
     runs-on: ubuntu-latest
     timeout-minutes: 10
     needs: cache-warmer
-    # strategy:
-    #   matrix:
-    #     node-version: [ 16.x, 18.x, 20.x ]
+    strategy:
+      matrix:
+        node-version: [ 16.x, 18.x, 20.x ]
     env:
       ACTIONS_ALLOW_UNSECURE_COMMANDS: true
 
@@ -136,10 +134,9 @@ jobs:
         id: setup
         with:
           cache: pnpm
-          node-version-file: .nvmrc
+          node-version: ${{ matrix.node-version }}
 
       - name: Install deps
-        id: install
         run: pnpm install --frozen-lockfile
 
       - name: Lint

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "eslint-config-kingstinct",
-  "version": "5.1.0",
+  "version": "5.1.1",
   "description": "ESLint configuration for React-native based on Airbnb with some great tweaks",
   "main": "index.js",
   "author": {

diff --git a/readme.md b/readme.md
@@ -1,5 +1,6 @@
 # eslint-config-kingstinct
 
+[![npm (scoped)](https://img.shields.io/npm/v/eslint-config-kingstinct)](https://www.npmjs.com/package/eslint-config-kingstinct)
 ![CI Status](https://github.com/kingstinct/eslint/workflows/Node.js%20CI/badge.svg)
 
 ## Principles