Skip to content

Commit

Permalink
Merge pull request storyprotocol#14 from piplabs/uma-request
Browse files Browse the repository at this point in the history
Remove pause modifier from assertionResolvedCallback()
  • Loading branch information
Spablob authored Jan 9, 2025
2 parents 788199e + 197fc9e commit 8442d34
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 11 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -248,10 +248,7 @@ contract ArbitrationPolicyUMA is
/// @notice OOV3 callback function forwhen an assertion is resolved
/// @param assertionId The resolved assertion identifier
/// @param assertedTruthfully Indicates if the assertion was resolved as truthful or not
function assertionResolvedCallback(
bytes32 assertionId,
bool assertedTruthfully
) external nonReentrant whenNotPaused {
function assertionResolvedCallback(bytes32 assertionId, bool assertedTruthfully) external nonReentrant {
ArbitrationPolicyUMAStorage storage $ = _getArbitrationPolicyUMAStorage();
if (msg.sender != address($.oov3)) revert Errors.ArbitrationPolicyUMA__NotOOV3();

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -776,13 +776,6 @@ contract ArbitrationPolicyUMATest is BaseTest {
newArbitrationPolicyUMA.disputeAssertion(assertionId, counterEvidenceHash);
}

function test_ArbitrationPolicyUMA_assertionResolvedCallback_revert_paused() public {
newArbitrationPolicyUMA.pause();

vm.expectRevert(abi.encodeWithSelector(PausableUpgradeable.EnforcedPause.selector));
newArbitrationPolicyUMA.assertionResolvedCallback(bytes32(0), false);
}

function test_ArbitrationPolicyUMA_assertionDisputedCallback_revert_NotOOV3() public {
vm.expectRevert(Errors.ArbitrationPolicyUMA__NotOOV3.selector);
newArbitrationPolicyUMA.assertionDisputedCallback(bytes32(0));
Expand Down

0 comments on commit 8442d34

Please sign in to comment.